Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Investigate potential benefits of replacing hash-to-index mappings with Rcs

Description

We want to investigate the potential to replace the newly-implemented mappings of hashes to usize indices with Rc pointers to the hashes.

It's hoped that this might have a smaller impact on the code, while not costing us a significant drop in performance.

We need to consider whether to try to replace one of the exiting instances of such a mapping (probably the one relating to Event s would be simpler to use than the PeerId one) in order to examine the results, or whether to try to create a separate throwaway crate which will need to roughly replicate the behaviour of Parsec wrt such a mapping (i.e. have similar numbers of elements and similar ratio of insertions/accesses/deletions)

Environment

None

Activity

Show:

Pierre Chevalier 
March 26, 2019 at 2:52 PM

From a short discussion with Fraser, we don't think it's worth pursuing this task at this stage. Marking as obsolete.

Fraser Hutchison 
December 24, 2018 at 11:28 AM

I've now experimented with replacing the index mapping for Event s and also PeerId s. Neither attempt significantly appeared to simplify the codebase, and given the impact these chages would have, it seems to be not worth the effort to make the significant amount of changes, purely in the interests of a minimal reduction in code complexity.

I'll pause this task for now pending review/discussion with .

Unresolved

Details

Assignee

Reporter

Labels

Start date

End date

Story Points

Components

Priority

Parent

Created December 19, 2018 at 9:38 AM
Updated March 26, 2019 at 2:52 PM