Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Replace rust_sodium dependency in Routing with safe_crypto

Description

Replace all instances of *rust_sodium* functions usage with the corresponding safe_crypto functions.

So Routing has *SecretId* which is called *FullId* and *PublicId* will be replaced by primitives in *safe_cypto*. Mock-crypto feature in routing tries to mock all these, but now it shouldn't be required as *safe_crypto* does it with {{*features=use-mock-crypto*}} *--features=mock* so delete those code and pass that feature to *safe_crypto* when routing is compiled with use-mock-crypto.

Check build and test status for no features, feature=use-mock-crust and feature="use-mock-crust use-mock-crypto".

Environment

None

Gliffy Diagrams

Activity

Stephen Coyle September 6, 2018 at 9:42 AM

E2E tests passed. Churn & invariant checks all look fine.

Ran soak tests (500 iterations) which showed up a reproducible problem with the test `rate_limiter::tests::many_clients`.
This would require input from the Routing team so waiting for a team member to become available to investigate.

Testing notes & further details - https://gist.github.com/S-Coyle/27ccb5d8ba57f207d519e5ec9753122e

Povilas Balciunas August 29, 2018 at 11:55 AM

will also run end to end tests to confirm my changes haven't broken anything

Povilas Balciunas July 27, 2018 at 11:51 AM

Will pause until the future of safe_crypto is clear.

Nikita Baksalyar July 2, 2018 at 12:51 PM

Paused - switching to MAID-2725. Now is going to work on this task.

Nikita Baksalyar June 25, 2018 at 11:55 AM

Details

Assignee

Reporter

Start date

End date

Story Points

Components

Priority

Parent

Created May 29, 2018 at 11:50 AM
Updated July 3, 2019 at 1:50 PM