check for all muts (eg., response_getter etc) and validate if really required

No worries.

Hey @sidr Though it's a trivial task, i would still put a hold on this because it depends on the nfs and client crate changes .. So it's more of an inspection task but i would like to see if any of the changes there would cause anything to break here. Hope you don't mind the task held up in review until sometime next week. I'll write here if i find anything in the meantime.

Cheers @sidr, if you can push this task to review and assign it to @Spandan Sharma, we can review and close this task.

nice one. I allocated you the task, if you can confirm your findings then please mark as in-progress then on to review thx very much

Just looked at this issue and here is what I found. I am not sure how to claim the task, so just commenting here.

There are total 5 mut variables in self_dns.

In dns_configuration.rs, both reader(line 48) and writer(line 63) call prepare_window() (via reader.read and writer.write) on Sequencer in self_encryption crate. This function modifies the underlying struct and hence the entire chain needs to be mut.

In mod.rs the mut variables on line 49, 85 and 177 are all modified after initialization. So they need to be mut.

So they are no unnecessary muts.